Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule no-deprecated-report-api should consider spread operator #64

Closed
aladdin-add opened this issue Oct 24, 2018 · 2 comments
Closed

rule no-deprecated-report-api should consider spread operator #64

aladdin-add opened this issue Oct 24, 2018 · 2 comments
Labels
accepted bug rule

Comments

@aladdin-add
Copy link
Contributor 

                errors.forEach(error => {
                    context.report(...error);
                });

it was found in https://github.com/eslint/eslint/blob/3943635e10c6cf47d3268c91baf9e24c07401af9/lib/rules/no-irregular-whitespace.js#L226-L228
@not-an-aardvark
Copy link
Contributor

I agree, I think this should be considered a bug.

@aladdin-add
Copy link
Contributor Author

working on this.

aladdin-add added a commit that referenced this issue Oct 24, 2018
@aladdin-add
Fix: no-deprecated-report-api should consider spread operator(fixes #64)
f5a40c0
not-an-aardvark added a commit to eslint/eslint that referenced this issue Oct 24, 2018
@not-an-aardvark
Chore: avoid using legacy report API in no-irregular-whitespace
6c6a5fd 
This updates the no-irregular-whitespace rule to avoid using the legacy multi-argument `context.report` API. We have a linting rule to enforce against using the API, but the rule wasn't enforcing it in this case.

This was originally found by Aladdin-ADD in eslint-community/eslint-plugin-eslint-plugin#64.
@not-an-aardvark not-an-aardvark mentioned this issue Oct 24, 2018
Merged
aladdin-add added a commit that referenced this issue Oct 24, 2018
@aladdin-add
Fix: no-deprecated-report-api should consider spread operator(fixes #64)
5473e50
not-an-aardvark added a commit to eslint/eslint that referenced this issue Oct 24, 2018
@not-an-aardvark
Chore: avoid using legacy report API in no-irregular-whitespace
6dc4eda 
This updates the no-irregular-whitespace rule to avoid using the legacy multi-argument `context.report` API. We have a linting rule to enforce against using the API, but the rule wasn't enforcing it in this case.

This was originally found by Aladdin-ADD in eslint-community/eslint-plugin-eslint-plugin#64.
not-an-aardvark added a commit to eslint/eslint that referenced this issue Oct 24, 2018
@not-an-aardvark
Chore: avoid using legacy report API in no-irregular-whitespace (#11013)
3d88b38 
This updates the no-irregular-whitespace rule to avoid using the legacy multi-argument `context.report` API. We have a linting rule to enforce against using the API, but the rule wasn't enforcing it in this case.

This was originally found by Aladdin-ADD in eslint-community/eslint-plugin-eslint-plugin#64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted bug rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@not-an-aardvark @aladdin-add