Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: test on eslint v8 (fixes #175) #186

Merged
merged 7 commits into from Oct 11, 2021
Merged

Build: test on eslint v8 (fixes #175) #186

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e48a468
--wip-- [skip ci]
aladdin-add Sep 24, 2021
bd074ef
Build: test on eslint v8
aladdin-add Sep 24, 2021
1918a97
chore: upgrade to 8.0.0-rc.0
aladdin-add Sep 26, 2021
4da0f48
fix: use fisker/eslint-plugin-unicorn
aladdin-add Sep 26, 2021
db7131e
chore: upgrade espree & eslint-scope to use the same version as eslin…
aladdin-add Sep 26, 2021
490a700
Update package.json
aladdin-add Sep 27, 2021
a4629d1
Update package.json
aladdin-add Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Expand Up @@ -22,7 +22,8 @@ jobs:
- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
- run: npm install
# TODO: remove "--force" once eslint v8 released
- run: npm install --force
- run: npm test

lint:
Expand All @@ -41,3 +42,13 @@ jobs:
- run: npm install
- run: npm install --save-dev eslint@6
- run: npm test

eslint7:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- run: npm install
- run: npm install --save-dev eslint@7
- run: npm test

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -42,12 +42,12 @@
"@not-an-aardvark/node-release-script": "^0.1.0",
"chai": "^4.1.0",
"dirty-chai": "^2.0.1",
"eslint": "^7.9.0",
"eslint": "8.0.0-rc.0",
aladdin-add marked this conversation as resolved.
Show resolved Hide resolved
"eslint-config-not-an-aardvark": "^2.1.0",
"eslint-plugin-markdown": "^2.0.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-self": "^1.2.1",
"eslint-plugin-unicorn": "^36.0.0",
"eslint-plugin-unicorn": "github:fisker/eslint-plugin-unicorn#eslint-8",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: replace the fork once it get merged and released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can proceed with this fork for now:

  • Most importantly, eslint-plugin-unicorn is an internal-only dev-dependency, and we shouldn't let a non-essential dev-dependency that has no public-facing impact to our consumers block us from releasing our plugin
  • The fork is owned by the maintainer of eslint-plugin-unicorn
  • We can pin to a specific commit of the fork branch if desired
  • Other repositories are using this fork to unblock themselves while awaiting for the official fix to be released

Related: platinumazure/eslint-plugin-qunit#209

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine, let's do it!

"eslint-scope": "^5.1.1",
"espree": "^7.3.0",
"estraverse": "^5.0.0",
Expand Down