Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export the moduleType from ImportTarget #132

Merged
merged 3 commits into from Nov 7, 2023

Conversation

scagood
Copy link

@scagood scagood commented Oct 26, 2023

This is a slightly different approach to solve #21.

In this case we only try to add extensions to relative and absolute paths, with the detection of the moduleTypes done inside the ImportTarget

Copy link

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit ff01930 into eslint-community:master Nov 7, 2023
15 checks passed
@aladdin-add
Copy link

just a reminder: you can use "closes #xxx" or "fixes #xxx" in the description. so, the linked issue can be auto closed. 😄

@scagood
Copy link
Author

scagood commented Nov 7, 2023

just a reminder: you can use "closes #xxx" or "fixes #xxx" in the description. so, the linked issue can be auto closed. 😄

I keep forgetting 🤦

Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants