Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: The readme says this supports ESLint >=7.0.0, but ruleContext.physicalFilename doesn't exist in version 7.15.0 on my machine #155

Closed
1 task
SlyryD opened this issue Dec 30, 2023 · 2 comments · Fixed by #156
Assignees

Comments

@SlyryD
Copy link

SlyryD commented Dec 30, 2023

Bug: The readme says this supports ESLint >=7.0.0, but ruleContext.physicalFilename (used in is-typescript.js) doesn't exist in eslint version 7.15.0 on my machine

Environment

Node version: 18.17.0
npm version: 9.6.7
ESLint version: 7.15.0
eslint-plugin-n version: 16.6.0
Operating System: Windows 11

What rule do you want to report?

n/no-missing-import

Link to Minimal Reproducible Example

playground apparently doesn't work with eslint 7.15.0

What did you expect to happen?

I expected eslint version 7.15.0 to work, but instead eslint-plugin-n throws TypeError "context.getPhysicalFilename is not a function"

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response

@SlyryD SlyryD added the bug label Dec 30, 2023
@SlyryD
Copy link
Author

SlyryD commented Dec 30, 2023

I got the same issue on eslint 7.32.0, so I expect the readme just needs to be updated to say this project Requires ESLint >=8.0.0. Never mind, eslint 7.32.0 works for me. So the readme and peerDependencies should be updated.

@SlyryD
Copy link
Author

SlyryD commented Dec 30, 2023

It looks like it was added in eslint 7.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants