feat(import-target): Add resolution error reason #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
force-pushed
the
pr231
branch
4 times, most recently
from
86b6cd7
to
4fd0965
Compare
scagood
approved these changes
May 6, 2024
Comment on lines
+18
to
+21
| const platform = os.platform() | ||
| exports.isCaseSensitiveFileSystem = | ||
| platform === "linux" || platform === "freebsd" || platform === "openbsd" | ||
|
|
There was a problem hiding this comment.
Can we make this in a different file? I don't think it belongs with the rule tester
There was a problem hiding this comment.
right, renamed to test-helpers. :)
| @@ -8,12 +8,17 @@ const { RuleTester } = require("eslint") | |||
| const { FlatRuleTester } = require("eslint/use-at-your-own-risk") | |||
There was a problem hiding this comment.
I am starting to think we should make these patches for different eslint versions into a package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed test cases (based on #231).
fixes #182