Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long term home of eslint-plugin-n #8

Closed
voxpelli opened this issue Jan 31, 2022 · 18 comments
Closed

Long term home of eslint-plugin-n #8

voxpelli opened this issue Jan 31, 2022 · 18 comments

Comments

@voxpelli
Copy link
Member

As discussed in a previous thread with eg. me, you @aladdin-add, @MichaelDeBoey: standard/eslint-config-standard#192 (comment)

Having an eslint-community organization (or similar) that's home to this module + eslint-plugin-promise and other important modules would be good .

@aladdin-add You mentioned that @nzakas were setting up an eslint-community organization, do you know anything more?

@MichaelDeBoey
Copy link
Member

Would be lovely if we could move eslint-plugin-node, eslint-plugin-es, eslint-utils, @mysticatea/eslint-plugin & eslint-plugin-promise to this new org too

@nzakas
Copy link

nzakas commented Feb 1, 2022

There’s nothing more to report right now. We’ve got some other higher priority tasks I need to work on first. Stay tuned to the blog and Twitter for updates.

@MichaelDeBoey
Copy link
Member

@nzakas If there's some work we can take out of your hands, I'm happy to help out!

@voxpelli
Copy link
Member Author

voxpelli commented Feb 1, 2022

eslint-community is mentioned in eslint/eslint#15383

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Feb 4, 2022

It seems like the team agreed to not make it a priority: eslint/eslint#15383 (comment) 🤔

@aladdin-add
Copy link

However, I did not see it was discussed in the meeting. :-( 

Anyway, the only thing is to write a RFC to talk about how it runs: https://github.com/eslint/rfcs

@thernstig
Copy link

thernstig commented Mar 23, 2022

Definitely go for eslint-community once its been setup by ESLint maintainers, it will give it a well-known home :)

Then it can live in npm under @eslint/eslint-plugin-node possibly.

@nazrhyn
Copy link

nazrhyn commented Mar 24, 2022

Keeping the name via a namespace like that would be awesome, as well as having these under an org. Looking forward to the changes!

@voxpelli
Copy link
Member Author

Created a discussion around this in the ESLint repo: eslint/eslint#15929

@voxpelli
Copy link
Member Author

And now an RFC regarding this is up: eslint/rfcs#91

@MichaelDeBoey
Copy link
Member

Let's hope, we can transfer the original repo asap to the new @eslint-community org 🙏

mysticatea#341

@thernstig
Copy link

Would it be time to consider that https://github.com/mysticatea/eslint-plugin-node (see mysticatea#341) will not be transfered? And instead transfer this repo?

@MichaelDeBoey
Copy link
Member

@thernstig We're working on transferring @mysticatea's repos one at a time

@aladdin-add
Copy link

aladdin-add commented Jan 28, 2023

a few months passed, but we are still not able to transfer the original repo( we have not gotten response from @mysticatea 😢). I think it's time to make the new @eslint-community/eslint-plugin-node.

I have the following plans:

  1. checkout a new branch from the original main.
  2. pick all the features/bugfixes from eslint-plugin-n.
  3. transfer the opened issues/PRs to the new repo.
  4. review & merge the "ready" PRs.
  5. release @eslint-community/eslint-plugin-node v1.0.
  6. make the eslint-plugin-n as an alias of the new package. (DX matters! 😄 )

questions:

  • does anyone have the admin access to https://github.com/mysticatea/eslint-plugin-node, please add me. cc @ota-meshi
  • how can I get the publish access to @eslint-community/eslint-plugin-node? cc @MichaelDeBoey
  • should the new package be another repo? I'd slightly prefer renaming the repo back to eslint-plugin-node, but open to create a new one to avoid possible confusion.

@nazrhyn
Copy link

nazrhyn commented Jan 28, 2023

I think the horizontal name changes happen regularly enough (e.g. apollo-server -> @apollo/server) that eslint-plugin-node -> @eslint-community/eslint-plugin-node makes sense. Even makes it seem "official", which is probably good.

@voxpelli
Copy link
Member Author

@aladdin-add I think we should keep working in this repo unless we can move the original repo here

I am pro on renaming this repo to eslint-plugin-node

I think this issue should be considered resolved when #55 is resolved

@scagood
Copy link

scagood commented Jan 11, 2024

As #55 is closed shall we close this?

@voxpelli
Copy link
Member Author

@scagood Yeah, I think a rename to @eslint-community/eslint-plugin-node or such is a bit late to do now anyway and out of scope of this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants