Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken rule documentation links #61

Closed
jaydenseric opened this issue Jun 4, 2017 · 2 comments · Fixed by #86 or #91
Closed

Broken rule documentation links #61

jaydenseric opened this issue Jun 4, 2017 · 2 comments · Fixed by #86 or #91
Assignees

Comments

@jaydenseric
Copy link

Error tooltip rule documentation links in tools like Atom linter-eslint are broken.

For example, https://github.com/xjamundx/eslint-plugin-promise#catch-or-return should be https://github.com/xjamundx/eslint-plugin-promise#rule-catch-or-return.

@macklinu
Copy link
Contributor

macklinu commented Feb 5, 2018

Looking into this, it seems like Atom's linter-eslint package tries to determine a rule URL if one does not exist - check out this code.

One area of improvement for each rule in this plugin would be to refactor to include the meta.docs.url field.

For example, the catch-or-return rule would go from looking like this:

module.exports = {
  create: function (context) {
    // ...snippet
  }
}

To this:

module.exports = {
  meta: {
    docs: {
      url: 'https://github.com/xjamundx/eslint-plugin-promise#rule-catch-or-return'
    }
  },
  create: function (context) {
    // ...snippet
  }
}

I am sure PRs are welcome for this contribution - can probably take a look this week, but feel free to comment if you'd like to contribute this, @jaydenseric. 🙂

@macklinu
Copy link
Contributor

macklinu commented Feb 7, 2018

This wasn't resolved in #86 - mistyped in that PR description. Will resolve this issue in another PR.

macklinu added a commit that referenced this issue Feb 7, 2018
macklinu added a commit that referenced this issue Feb 7, 2018
macklinu added a commit that referenced this issue Feb 7, 2018
macklinu added a commit that referenced this issue Feb 7, 2018
macklinu added a commit that referenced this issue Feb 7, 2018
macklinu added a commit that referenced this issue Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants