chore(package): add package-lock.json #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
This PR introduces a
package-lock.jsonfile. Some updates to@babel/code-framewere causing build failures (as Jest includes this as a dependency). Locking to version 7.0.0-beta.46 resolved the issue on Node 4.I think introducing a lockfile makes sense. I'm not sure what the long term ramifications of Jest and Babel are and how Node 4 will be fully supported moving forward. This works for now, but is something to keep an eye on.
I also made some changes to the Travis build script to use npm ci for installing modules.