Fixed that no-return-wrap does not work if type is not "ExpressionStatement".
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ota-meshi can you rebase |
|
I'm so bad at maintaining this module. I'm basically fine with this change if we can rebase it. |
ota-meshi
force-pushed
the
fix/no-return-wrap
branch
from
bacfed5
to
d8b9206
Compare
|
Hello! |
|
Please wait a minute. |
|
I added testcase of #150, and added |
|
Thanks |
|
/cc @xjamundx Friendly ping again |
|
k looking |
|
/cc @xjamundx can we merge and release new version? |
|
I'll be honest, I don't really understand when/why this would be useful, but the code looks fine and I will release. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
no-return-wrapdoes not work if type is not "ExpressionStatement".(ex. "ReturnStatement" argument,"CallExpression" argument)
no-return-wrapdoes not work if multiple "ExpressionStatement" exists in the ancestor of "ReturnStatement".What changes did you make? (Give an overview)
I changed to search for the ancestor of "FunctionExpression" closest to "ReturnStatement" and to check if the parent node of that "FunctionExpression" is
Promise.Close #150