fix(no-return-wrap): fix it not reporting for arrow functions without braces #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome work. Will check this out tomorrow
…On Wed, Jul 1, 2020 at 9:39 PM cherryblossom000 ***@***.***> wrote:
*What is the purpose of this pull request?*
- Documentation update
- Bug fix
- New rule
- Changes an existing rule
- Add autofixing to a rule
- Other, please explain:
*What changes did you make? (Give an overview)*
Checks CallExpressions that are direct descendants of
ArrowFunctionExpressions (meaning that the arrow function returns a
CallExpression without braces) and reports if it is Promise.resolve or
Promise.reject.
Fixes #193 <#193>.
------------------------------
You can view, comment on, or merge this pull request online at:
#194
Commit Summary
- fix(no-return-wrap): fix it not reporting for arrow functions
without braces (fixes #193)
File Changes
- *M* __tests__/no-return-wrap.js
<https://github.com/xjamundx/eslint-plugin-promise/pull/194/files#diff-c1a407fe4cb81dd27109daaac1014495>
(22)
- *M* rules/no-return-wrap.js
<https://github.com/xjamundx/eslint-plugin-promise/pull/194/files#diff-1ec5f1ff7a25f9ea1a76881d04f6f92d>
(40)
Patch Links:
- https://github.com/xjamundx/eslint-plugin-promise/pull/194.patch
- https://github.com/xjamundx/eslint-plugin-promise/pull/194.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#194>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4C76MNGJI76K22WL6TLTRZQFPLANCNFSM4OOQDNJA>
.
|
|
This is great. I haven't published any updates to this repo in ages, so it may take a minute, but thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Checks CallExpressions that are direct descendants of ArrowFunctionExpressions (meaning that the arrow function returns a CallExpression without braces) and reports if it is
Promise.resolveorPromise.reject.Fixes #193.