chore: add license #204
Merged
chore: add license #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ISC one (as specified in package.json) from GitHub template https://github.com/licenses/license-templates/blob/master/templates/isc.txt
| @@ -0,0 +1,13 @@ | |||
| Copyright (c) 2020, xjamundx | |||
There was a problem hiding this comment.
Suggested change
| Copyright (c) 2020, xjamundx | |
| Copyright (c) 2016, xjamundx |
Please review this. I believe it should be 2016, @xjamundx Correct me if I'm wrong and don't know if we should keep your {{github_username}} as the {{ organization }} or it's better to add your name instead i.e., Jamund Ferguson.
There was a problem hiding this comment.
I think it should be my name, yes, but I can probably do this.
There was a problem hiding this comment.
@xjamundx Awesome, thanks for the update.
|
@davidlj95 Thanks for the PR. 🎉 Let's wait for @xjamundx 's comment on whether the details mentioned in the license are correct or it still needs any change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Update LICENSE according to license specified in
package.jsonISC one (as specified in package.json) from GitHub template
https://github.com/licenses/license-templates/blob/master/templates/isc.txt
What changes did you make? (Give an overview)