Conflict with ESLint quotes "backtick"

[fxedel]

In our project, we decided to always use template literals with backticks instead of normal quotes as Template Literals are Strictly Better Strings. So we want to use const str = `text`; instead of const str = 'text';. See our issue on that topic.

Unfortunately, this plugin conflicts with that rule:

const fs = require('fs'); // error by ESLint's quotes rule
const fs = require(`fs`); // warning by this plugin's detect-non-literal-require rule
// -> No possibility to use require without errors/warnings

All rules enforcing a literal usage pass with single ticks and fail with back ticks, without respecting whether or not the template string does actually contain variables.

The rules actually check the argument's type to be 'Literal' (rules/detect-non-literal-require.js#L18), maybe it's possible to also check to case that the argument is non-literal, but is a template string doesn't containing any variables?

[jesusprubio]

Summary
False positive with requires if using backticks as literal.

Still relevant?
Yes.

Next steps

• Review and merge this PR: Add non-literal-require support for TemplateLiteral #32
• Close this issue.

[ota-meshi]

I believe it is fixed in v1.5.0.