feat(non-literal-require): support template literals #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently following code triggers the detect-non-literal-require rule:
```js
const foo = require(`bar`)
```
However it would be more accurate (and less noisey) if it triggered on
cases such as:
```js
const foo = require(`${bar}`)
```
nzakas
requested changes
Mar 29, 2022
MarkKragerup
changed the title
|
@nzakas removed the babel-eslint dependency and cleaned it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not have write access to the fork for #32, so i forked the fork and implemented the following changes:
https://github.com/eslint/eslint/blob/main/docs/user-guide/migrating-to-6.0.0.md#rule-tester-parser
This closes #29 and #27
@nzakas Can you close #32 in favor of this pr, and possibly merge?