Linter and formatter

[jesusprubio]

What about using an style guide? I'm starting to use the AirBnb one in all my projects. This are the reasons:

• One of the most completes.
• ES6.
• ESLint setup file available with checks for everything covered in the Style guide.

More options:

• http://noeticforce.com/best-javascript-style-guide-for-maintainable-code
• https://github.com/feross/standard

I really don't care about which one, but IMHO we need to use one if we keep working in this awesome project. :)

[wraithgar]

This is the eslint style plugin we use for nsp stuff https://github.com/nodesecurity/eslint-config-nodesecurity

[jesusprubio]

Nice, it's almost equal the one I like :). I've changed the style of the code of my PR to respect it (#3).

If you want I can do it in the rest of the code once we merge the PR.

Thanks :)

[pdehaan]

I can do this after the 2 existing PRs are merged (to avoid massive collisions).
I'll probably run the current code through prettier and then add a basic ESLint setup to keep things slightly more kosher.

[pdehaan]

Briefly looked at this today and it was fairly painless w/ prettier CLI and ESLint's --fix flag. Only needed a bit of manual tweaking...

For my future reference, here's the configs:

{
  "extends": "nodesecurity",

  "root": true,

  "rules": {
    "hapi/hapi-scope-start": "off",

    "brace-style": "off",
    "func-style": "off",
    "no-var": "off",
    "prefer-arrow-callback": "off",
    "prefer-template": "off"
  }
}

and the package.json scripts block:

  "scripts": {
    "cont-int": "npm test && npm run lint",
    "format": "prettier '{rules/,test/,}*.js' --single-quote --write",
    "lint": "eslint .",
    "postformat": "npm run lint",
    "test": "mocha test/**/*"
  }

[pdehaan]

PR submitted as #20

[jesusprubio]

Due to the recent new of moving this project to ESLint organization #71 (comment), I propose to use the linter+formatter setup used there.

[jesusprubio]

Summary
This project setup lacks of a formatter. Moreover, IMHO a more common linter setup should help to get new contributions.

Still relevant?
Yes.

Next steps

• Research about the linter+formatter setup from ESLint organization.
• Adapt it to this project nature (if needed).
• Make a PR with the new setup and codebase update to respect it.

[jesusprubio]

I can resume the work in this one once we start to fix things.

[MarkKragerup]

@jesusprubio i did this on my fork. Let me suggest a PR that implements prettier and the default eslint recommendations

[jesusprubio]

Closing this one. Problem already solved here: #75