feat: use typescript #60

ota-meshi · 2023-02-06T05:24:09Z

This PR changes the source code to use typescript.

I also changed it to use unbuild for building. This will allow us to provide bundled d.ts.

codecov-commenter · 2023-02-06T05:33:12Z

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (32b8306) 96.96% compared to head (236faa8) 97.44%.
Report is 10 commits behind head on main.

Files	Patch %	Lines
src/get-string-if-constant.ts	77.77%	6 Missing ⚠️
src/reference-tracker.ts	98.92%	3 Missing ⚠️
src/get-property-name.ts	95.55%	2 Missing ⚠️
src/get-static-value.ts	98.79%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   96.96%   97.44%   +0.48%     
==========================================
  Files          13       14       +1     
  Lines        2111     2626     +515     
  Branches      396      406      +10     
==========================================
+ Hits         2047     2559     +512     
- Misses         63       66       +3     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json

.eslintrc.js

src/pattern-matcher.ts

MichaelDeBoey · 2023-07-29T20:20:46Z

src/reference-tracker.ts

@@ -49,23 +71,105 @@ function isPassThrough(node) {
    }
 }

+export interface ReferenceTrackerOptions {


Suggested change

export interface ReferenceTrackerOptions {

export type ReferenceTrackerOptions = {

MichaelDeBoey · 2023-07-29T20:37:02Z

src/has-side-effect.ts

+/**
+ * Options for `hasSideEffect`, optionally.
+ */
+export interface HasSideEffectOptions {


Suggested change

export interface HasSideEffectOptions {

export type HasSideEffectOptions = {

src/token-predicate.ts

ota-meshi · 2023-09-23T03:17:40Z

@MichaelDeBoey Sorry for the delay. Thank you for checking this PR.
I fixed this PR. Could you please check again?

MichaelDeBoey · 2023-09-30T15:18:30Z

src/get-static-value.ts

+     @eslint-community/mysticatea/eslint-comments/no-use:0,
+     @eslint-community/mysticatea/ts/no-unsafe-assignment:0,
+     @eslint-community/mysticatea/ts/no-unsafe-argument:0,
+     @eslint-community/mysticatea/ts/no-unsafe-return:0,
+     @eslint-community/mysticatea/ts/no-unsafe-member-access:0,
+     @eslint-community/mysticatea/ts/no-unsafe-call:0,


Suggested change

@eslint-community/mysticatea/eslint-comments/no-use:0,

@eslint-community/mysticatea/ts/no-unsafe-assignment:0,

@eslint-community/mysticatea/ts/no-unsafe-argument:0,

@eslint-community/mysticatea/ts/no-unsafe-return:0,

@eslint-community/mysticatea/ts/no-unsafe-member-access:0,

@eslint-community/mysticatea/ts/no-unsafe-call:0,

@eslint-community/mysticatea/eslint-comments/no-use:off,

@eslint-community/mysticatea/ts/no-unsafe-assignment:off,

@eslint-community/mysticatea/ts/no-unsafe-argument:off,

@eslint-community/mysticatea/ts/no-unsafe-return:off,

@eslint-community/mysticatea/ts/no-unsafe-member-access:off,

@eslint-community/mysticatea/ts/no-unsafe-call:off,

MichaelDeBoey · 2023-09-30T15:21:23Z

src/get-parent.ts

+import type * as ESTree from "estree"
+export function getParent(node: ESTree.Node): ESTree.Node | null {
+    // eslint-disable-next-line @eslint-community/mysticatea/ts/no-unsafe-member-access
+    return (node as any).parent as ESTree.Node | null


Can we somehow get rid of the as any cast?

MichaelDeBoey · 2023-09-30T15:21:44Z

src/get-static-value.ts

+declare const self: typeof globalThis
+declare const window: typeof globalThis
+
+const globalObject: Record<string, any> =


We should use unknown instead of any
https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html#any

Suggested change

const globalObject: Record<string, any> =

const globalObject: Record<string, unknown> =

MichaelDeBoey · 2023-09-30T15:22:21Z

src/get-static-value.ts

 */
-function getPropertyDescriptor(object, name) {
+function getPropertyDescriptor(object: any, name: number | string | symbol) {


Suggested change

function getPropertyDescriptor(object: any, name: number | string | symbol) {

function getPropertyDescriptor(object: unknown, name: number | string | symbol) {

MichaelDeBoey · 2023-09-30T15:22:33Z

src/get-static-value.ts

 */
-function isGetter(object, name) {
+function isGetter(object: any, name: number | string | symbol) {


Suggested change

function isGetter(object: any, name: number | string | symbol) {

function isGetter(object: unknown, name: number | string | symbol) {

MichaelDeBoey · 2023-09-30T15:25:21Z

src/pattern-matcher.ts

+function replaceF(
+    matcher: PatternMatcher,
+    str: string,
+    replace: (substring: string, ...args: any[]) => string,


Suggested change

replace: (substring: string, ...args: any[]) => string,

replace: (substring: string, ...args: unknown[]) => string,

MichaelDeBoey · 2023-09-30T15:25:31Z

src/pattern-matcher.ts

-    [Symbol.replace](str, replacer) {
+    public [Symbol.replace](
+        str: string,
+        replacer: string | ((substring: string, ...args: any[]) => string),


Suggested change

replacer: string | ((substring: string, ...args: any[]) => string),

replacer: string | ((substring: string, ...args: unknown[]) => string),

MichaelDeBoey · 2023-09-30T15:25:41Z

src/reference-tracker.ts


 const IMPORT_TYPE = /^(?:Import|Export(?:All|Default|Named))Declaration$/u
-const has = Function.call.bind(Object.hasOwnProperty)
+const has = Function.call.bind(Object.hasOwnProperty) as (
+    o: any,


Suggested change

o: any,

o: unknown,

MichaelDeBoey · 2023-09-30T15:26:23Z

test/find-variable.ts

        const linter = new eslint.Linter()
-        let variable = null
+        let variable: any = null


Suggested change

let variable: any = null

let variable: unknown = null

MichaelDeBoey · 2023-09-30T15:26:51Z

test/reference-tracker.ts

-                        )
-                    },
-                }))
+                let actual: any = null


Suggested change

let actual: any = null

let actual: unknown = null

github-actions · 2023-12-12T12:30:34Z

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that aren't actionable. Please reach out if you have more information for us! 🙂

voxpelli · 2024-03-04T13:20:21Z

@ota-meshi Shall we continue with this PR? I reopened #150 to track whether we can readd types in a different way

ota-meshi requested a review from a team February 6, 2023 05:28

ota-meshi force-pushed the use-ts branch 2 times, most recently from a163a5c to 5c60276 Compare March 3, 2023 02:15

ota-meshi force-pushed the use-ts branch from 5c60276 to 5e124a8 Compare March 17, 2023 02:37

ota-meshi force-pushed the use-ts branch from 2938302 to 899c71d Compare March 24, 2023 03:51

github-actions bot added the Stale label May 23, 2023

ota-meshi removed the Stale label May 26, 2023

github-actions bot added the Stale label Jul 25, 2023

MichaelDeBoey removed the Stale label Jul 29, 2023

MichaelDeBoey requested changes Jul 29, 2023

View reviewed changes

ota-meshi added 2 commits September 23, 2023 11:43

feat: use typescript

2c74bbb

fix: ci workflow

018bb7a

ota-meshi force-pushed the use-ts branch from 899c71d to 018bb7a Compare September 23, 2023 02:43

ota-meshi added 2 commits September 23, 2023 11:52

fix: lint error

711c2cb

fix: some changes

236faa8

ota-meshi requested a review from MichaelDeBoey September 23, 2023 03:22

MichaelDeBoey requested changes Sep 30, 2023

View reviewed changes

MichaelDeBoey mentioned this pull request Sep 30, 2023

chore: use type instead of interface eslint-community/regexpp#151

Open

MichaelDeBoey mentioned this pull request Oct 14, 2023

Consider adding typescript declarations? #150

Open

auvred mentioned this pull request Nov 14, 2023

Migrate to TypeScript eslint-stylistic/eslint-stylistic#70

Closed

github-actions bot added the Stale label Dec 5, 2023

github-actions bot closed this Dec 12, 2023

MichaelDeBoey reopened this Dec 20, 2023

github-actions bot removed the Stale label Dec 20, 2023

voxpelli mentioned this pull request Mar 8, 2024

feat: validate type comments and generate .d.ts #204

Open

voxpelli added a commit that referenced this pull request Mar 8, 2024

Mimic #60 and move build to lint step on CI

77cff12

scagood mentioned this pull request Mar 21, 2024

feat: typescript (jsdoc) checking and definition generation eslint-community/eslint-plugin-n#169

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use typescript #60

feat: use typescript #60

ota-meshi commented Feb 6, 2023

codecov-commenter commented Feb 6, 2023 •

edited by codecov bot

MichaelDeBoey Jul 29, 2023

MichaelDeBoey Jul 29, 2023

ota-meshi commented Sep 23, 2023

MichaelDeBoey Sep 30, 2023

MichaelDeBoey Sep 30, 2023

MichaelDeBoey Sep 30, 2023

MichaelDeBoey Sep 30, 2023

MichaelDeBoey Sep 30, 2023

MichaelDeBoey Sep 30, 2023

MichaelDeBoey Sep 30, 2023

MichaelDeBoey Sep 30, 2023

MichaelDeBoey Sep 30, 2023

MichaelDeBoey Sep 30, 2023

github-actions bot commented Dec 12, 2023

voxpelli commented Mar 4, 2024

	export interface ReferenceTrackerOptions {
	export type ReferenceTrackerOptions = {

	export interface HasSideEffectOptions {
	export type HasSideEffectOptions = {

	const globalObject: Record<string, any> =
	const globalObject: Record<string, unknown> =

	function getPropertyDescriptor(object: any, name: number \| string \| symbol) {
	function getPropertyDescriptor(object: unknown, name: number \| string \| symbol) {

	function isGetter(object: any, name: number \| string \| symbol) {
	function isGetter(object: unknown, name: number \| string \| symbol) {

	replace: (substring: string, ...args: any[]) => string,
	replace: (substring: string, ...args: unknown[]) => string,

	replacer: string \| ((substring: string, ...args: any[]) => string),
	replacer: string \| ((substring: string, ...args: unknown[]) => string),

feat: use typescript #60

Are you sure you want to change the base?

feat: use typescript #60

Conversation

ota-meshi commented Feb 6, 2023

codecov-commenter commented Feb 6, 2023 • edited by codecov bot

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ota-meshi commented Sep 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 12, 2023

voxpelli commented Mar 4, 2024

codecov-commenter commented Feb 6, 2023 •

edited by codecov bot