Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for eslint #2

Merged
merged 12 commits into from Jul 1, 2019
Merged

Update readme for eslint #2

merged 12 commits into from Jul 1, 2019

Conversation

jonaskello
Copy link
Collaborator

Fixes #1

@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   90.51%   90.51%           
=======================================
  Files          22       22           
  Lines         369      369           
  Branches       56       56           
=======================================
  Hits          334      334           
  Misses         26       26           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e858fb...2ba0491. Read the comment docs.

@jonaskello
Copy link
Collaborator Author

Looking into how they do docs over at typescript-eslint I found this line. It seems they call the eslint-docs tool there. However it is not installed as part of their monorepo. I tried to clone that repo and run npm run docs in packages/eslint-plugin but it gives an error that there is no lib folder. I'm not sure they are actually using this tool anymore. There is also some code to verify the readme here.

I think I'll do the table for the rules manually for now and the we can look into automating it later.

@jonaskello
Copy link
Collaborator Author

Note that this PR will only port the readme file to eslint and split out all the rule docs to separate files. It does not fix each rule doc, they will be ported in a future PR.

@jonaskello jonaskello merged commit 2f46d0e into master Jul 1, 2019
@jonaskello jonaskello deleted the update-readme-for-eslint branch July 1, 2019 18:52
@RebeccaStevens RebeccaStevens added the Type: Documentation Solely about the documentation of the project. label Jul 4, 2019
RebeccaStevens pushed a commit that referenced this pull request Jan 4, 2021
* Change some links

* Split to files

* Index

* Remove extra line

* Update installing and usage

* Update descriptions

* Update recommended rules and remove sample config

* Fix package name

* Add how to develop info

* Standard rules

* Fix wording

* Update rule info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Solely about the documentation of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update readme for eslint and split into smaller files
3 participants