Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define-config-support files #20

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

Shinigami92
Copy link
Contributor

see discussion in #14 (comment)

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for eslint-stylistic ready!

Name Link
🔨 Latest commit cbc0a4c
🔍 Latest deploy log https://app.netlify.com/sites/eslint-stylistic/deploys/652882c624682d0008fb9319
😎 Deploy Preview https://deploy-preview-20--eslint-stylistic.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu
Copy link
Member

antfu commented Oct 12, 2023

Why move from ts to js package? Tests seems to fail

@Shinigami92
Copy link
Contributor Author

Why move from ts to js package? Tests seems to fail

It's not a move
It's also now for js

@Shinigami92
Copy link
Contributor Author

I don't know why the tests are failing, the CI dont show either what's happening
I only committed files that are relevant
I assume it has something to do with external forks + PRs
These CI steps are only executed on PRs
Could you have a look yourself?

@antfu antfu merged commit f9d0829 into eslint-stylistic:main Oct 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants