Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Linter has the wrong version number in the demo #407

Closed
not-an-aardvark opened this issue Sep 9, 2017 · 0 comments · Fixed by eslint/eslint#9275
Closed

Linter has the wrong version number in the demo #407

not-an-aardvark opened this issue Sep 9, 2017 · 0 comments · Fixed by eslint/eslint#9275
Labels
triage An ESLint team member will look at this issue soon

Comments

@not-an-aardvark
Copy link
Member

The demo on eslint.org always uses the latest version of ESLint. However, the .version property in Linter in the demo always lags one version behind, because we build the demo file before updating the version number in package.json as part of the ESLint release script.

This prevents us from correctly displaying the version number in the demo (if we decided that displaying the version would be a useful feature).

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Sep 9, 2017
not-an-aardvark added a commit to eslint/eslint that referenced this issue Sep 9, 2017
(fixes eslint/archive-website#407)

This updates the `npm run gensite` script to run browserify as part of the site generation, rather than using whatever it finds in `build/eslint.js`. This has a few advantages:

* The built file will always be up-to-date (previously, it would reflect the state of the repository whenever `npm test` was last run).
* The gensite script won't fail if it's run on its own and there isn't a `build/` directory.
kaicataldo pushed a commit to eslint/eslint that referenced this issue Sep 10, 2017
(fixes eslint/archive-website#407)

This updates the `npm run gensite` script to run browserify as part of the site generation, rather than using whatever it finds in `build/eslint.js`. This has a few advantages:

* The built file will always be up-to-date (previously, it would reflect the state of the repository whenever `npm test` was last run).
* The gensite script won't fail if it's run on its own and there isn't a `build/` directory.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants