Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Docs: Display emoji/notice for rules with suggestions #860

Merged
merged 8 commits into from Jul 30, 2021
Merged

Docs: Display emoji/notice for rules with suggestions #860

merged 8 commits into from Jul 30, 2021

Conversation

bmish
Copy link
Sponsor Member

@bmish bmish commented Jul 23, 2021 •
edited

Fixes #859.

Other part required for this change: eslint/eslint#14830

@eslint-github-bot eslint-github-bot bot added the triage An ESLint team member will look at this issue soon label Jul 23, 2021
@netlify
Copy link

netlify bot commented Jul 23, 2021 •
edited

✔️ Deploy Preview for eslint ready!

🔨 Explore the source changes: b6ceb5f

🔍 Inspect the deploy log: https://app.netlify.com/sites/eslint/deploys/6102ee861ea44e00079f58d5

😎 Browse the preview: https://deploy-preview-860--eslint.netlify.app/docs/rules

@bmish bmish force-pushed the hasSuggestions-icon branch 2 times, most recently from 9b04a51 to aae6957 Compare July 23, 2021 21:37
@bmish bmish mentioned this pull request Jul 23, 2021
Merged
1 task
@bmish bmish force-pushed the hasSuggestions-icon branch 2 times, most recently from 640dd74 to afe7bf3 Compare July 23, 2021 23:30
@nzakas
Copy link
Member

nzakas commented Jul 24, 2021

Force-pushing seems to be messing up the deploy preview. There’s no need to force-push, you can keep adding new commits. We only check the first commit message so the pressure is off. :)

can you try adding a new commit to see if it triggers the deploy preview to regenerate?

@bmish
Copy link
Sponsor Member Author

bmish commented Jul 24, 2021

Will rules.yml get automatically regenerated at some point? I manually updated the relevant parts.

mdjermanovic
mdjermanovic reviewed Jul 25, 2021
View reviewed changes
docs/rules/README.md Outdated Show resolved Hide resolved
@mdjermanovic
Copy link
Member

Will rules.yml get automatically regenerated at some point? I manually updated the relevant parts.

Yes, it gets updated on each ESLint release. (not including prereleases)

nzakas
nzakas previously approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mdjermanovic
Copy link
Member

Preview LGTM!

Note about merging: If we want to merge this after we merge eslint/eslint#14830 and do the release, then we should undo the changes in _data/rules.yml. Otherwise, it will produce an invalid yml with duplicate keys.

@bmish
Copy link
Sponsor Member Author

bmish commented Jul 29, 2021

Sounds good. Just reverted _data/rules.yml. Mind re-approving / merging?

@nzakas nzakas merged commit d4fac44 into master Jul 30, 2021
@nzakas nzakas deleted the hasSuggestions-icon branch July 30, 2021 00:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdjermanovic mdjermanovic mdjermanovic left review comments

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
triage An ESLint team member will look at this issue soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add emoji and notice to indicate which rules provide suggestions
3 participants
@bmish @nzakas @mdjermanovic