feat: added yarn and pnpm installations #24
Conversation
|
Looks like we have some test failures. |
|
Will check |
|
I've re-run the ci, and it's ✅. 🎉 |
| type: "select", | ||
| name: "packageManager", | ||
| message: "Which package manager does your project use?", | ||
| initial: 0, |
There was a problem hiding this comment.
just wondering if it can be a smarter default by checking how it was run. e.g
`npm init/npx` => npm
`yarn create` => yarn
There was a problem hiding this comment.
We can probably do that by checking if we already have an existing package.lock or yarn.lock or pnpm lock file and default to package managers.
Also, we might want to change the text to Which package manager do you want to use?
There was a problem hiding this comment.
but someone may don't use lockfile, or the lockfile can be configured a different name?
the text change lgtm. 👍
There was a problem hiding this comment.
Thought of using something similar to this code eslint/eslint#13756 (comment)
but someone may don't use lockfile, or the lockfile can be configured a different name?
Not sure about this
Is there any other way to find currently configured package manager?
There was a problem hiding this comment.
No idea.(^人^)
or it can be another PR (an enhancement) I think.
There was a problem hiding this comment.
Yep. Also I've seen some projects with both package.lock and yarn.lock as well. At that time we might want to default to one of the two package managers 😅 .
There was a problem hiding this comment.
I don’t think there’s a good way to detect this. Just best to ask.
| type: "select", | ||
| name: "packageManager", | ||
| message: "Which package manager does your project use?", | ||
| initial: 0, |
There was a problem hiding this comment.
I don’t think there’s a good way to detect this. Just best to ask.
Added yarn and pnpm for installing dependencies
I've used eslint/eslint#13756 as base for this PR and added pnpm. I once tried to link
create-configwith eslint and things seemed to work fine with yarn berry version too.fixes: #20