Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw error and exit when package.json not found #27

Merged
merged 5 commits into from Apr 16, 2022
Merged

fix: throw error and exit when package.json not found #27

merged 5 commits into from Apr 16, 2022

Conversation

harish-sethuraman
Copy link
Member

@eslint-github-bot eslint-github-bot bot added triage bug Something isn't working labels Apr 4, 2022
aladdin-add
aladdin-add reviewed Apr 4, 2022
View reviewed changes
lib/init/config-initializer.js Outdated Show resolved Hide resolved
lib/init/config-initializer.js Outdated Show resolved Hide resolved
lib/init/config-initializer.js Outdated Show resolved Hide resolved
lib/init/config-initializer.js Outdated Show resolved Hide resolved
aladdin-add
aladdin-add requested changes Apr 7, 2022
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change LGTM, can you please add a test?

harish-sethuraman
harish-sethuraman commented Apr 9, 2022
View reviewed changes
Copy link
Member Author

@harish-sethuraman harish-sethuraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the process exit and error console and replaced it with Error and wrote test for the same

aladdin-add
aladdin-add approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@harish-sethuraman
Copy link
Member Author

Bump

@aladdin-add @snitin315
Update lib/init/config-initializer.js
c3fa296 
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
@harish-sethuraman @snitin315
Update tests/init/config-initializer.js
a4e0de5 
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
snitin315
snitin315 approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 changed the title fix: exit when node project not found fix: throw error and exit when package.json not found Apr 16, 2022
@snitin315 snitin315 merged commit dbd5e34 into eslint:main Apr 16, 2022
@harish-sethuraman harish-sethuraman deleted the early-exit-process branch April 16, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harish-sethuraman @aladdin-add @snitin315