chore: Remove unused code #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows us to remove the `fs-teardown` dependency.
With the other two unused helpers removed, `index.js` now just re-exports a single import. This commit removes it and updates the two imports to point to the underlying file.
ESLint's CLI uses `.messageTemplate` to pretty-print errors, but no such functionality exists in `@eslint/create-config`.
aladdin-add
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was researching eslint/eslint#15559 using this repository as a smaller sandbox and found a few bits of now-unused code, including an unnecessary dependency. Review this one commit at a time. All the changes are small, so I put them in this one PR, but I'd be happy to split them out into individual PRs if that's easier to review.