Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add Node v19 #44

Merged
merged 2 commits into from Nov 5, 2022
Merged

ci: add Node v19 #44

merged 2 commits into from Nov 5, 2022

Conversation

mdjermanovic
Copy link
Member

@snitin315
Copy link
Contributor

Looks like we have a test failiure.

@mdjermanovic
Copy link
Member Author

I'll check it now, it seems that JSON.parse() error messages are different in v19.

@mdjermanovic
Copy link
Member Author

Messages are totally different:

  • Unexpected token v in JSON at position 9
  • Expected ':' after property name in JSON at position 9

I think it's good enough to check if the word "JSON" appears in the message?

snitin315
snitin315 approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good enough to check if the word "JSON" appears in the message?

Yeah, should be good enough.

@snitin315 snitin315 added accepted and removed triage labels Nov 5, 2022
@snitin315 snitin315 merged commit 66cc96c into main Nov 5, 2022
@snitin315 snitin315 deleted the node-19 branch November 5, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
accepted build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdjermanovic @snitin315