Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Added support for numeric and string literal types (fixes #156) #172

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

mister-walter
Copy link
Contributor

Added support to typed.js for string and numeric literals in types.

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@mister-walter
Copy link
Contributor Author

@jquerybot I signed the CLA and tried changing the author information on the commit, but it seems like the CLA check hasn't been rerun yet. Hopefully replying to the jquerybot will work.

@nzakas
Copy link
Member

nzakas commented Aug 19, 2016

Can you add a test that contains the example from the issue? Also, please update your commit message to include the issue number.

@mister-walter mister-walter changed the title Added support for numeric and string literal types Added support for numeric and string literal types (fixes #156) Aug 22, 2016
Added support to typed.js for string and numeric literals in types.
@mister-walter
Copy link
Contributor Author

@nzakas All set, sorry about that! I put the example from the issue inside the 'parse' area of test/parse.js, hopefully that is an appropriate place for it.

@nzakas
Copy link
Member

nzakas commented Aug 22, 2016

That is perfect, thanks!

@nzakas nzakas merged commit 12c7ad9 into eslint:master Aug 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants