This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
[BugFix] Incorrect behavior when arrow functions are used as default values #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lorefnon
force-pushed
the
bugfix/default-arrow-fn
branch
2 times, most recently
from
f0a58a5
to
3e7b614
Compare
lorefnon
force-pushed
the
bugfix/default-arrow-fn
branch
from
3e7b614
to
f052fe0
Compare
|
Can this be reviewed by someone ? |
|
Can someone look into this ? |
platinumazure
approved these changes
Jun 27, 2017
|
I see. Thanks for reviewing. |
|
@eslint/eslint-team Can someone else review this? I'm happy to merge if we can get one more set of eyes on this. |
kaicataldo
approved these changes
Jun 27, 2017
|
@lorefnon Sorry about the delay on this! There isn't a lot of traffic in this repo and it's easy to miss things. Thanks for the contribution! |
not-an-aardvark
approved these changes
Jun 27, 2017
gyandeeps
approved these changes
Jun 27, 2017
|
Merged, thanks @lorefnon for contributing! (And thanks very much for your patience!) |
|
Glad to see this merged. |
|
Can you please release this ? |
tmcw
pushed a commit
to documentationjs/doctrine
that referenced
this pull request
Apr 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When arrow functions are used as default values in arguments, the output is currently incorrect.
Example:
Expected default value in generated documentation:
() => {}Current default value in generated documentation:
()