This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
fix: Allow array indexes in names #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nzakas I'd be happy to help review & merge PRs if you're interested in extra help on the doctrine side! |
|
@tmcw Sorry about huge delay in responding. Most of ESLint team is not very familiar with doctrine. We could definitely use some help with reviewing PRs. |
|
@tmcw Is this something you'd still be interested in? |
|
Yep, can someone grant me the ability to do reviews / merge etc? |
not-an-aardvark
approved these changes
Aug 18, 2017
There was a problem hiding this comment.
Looks good to me. Thanks!
@tmcw As you probably noticed, I added you to the eslint/doctrine-team team, so you should now have write access to this repository.
|
I’m looking for the emoji for gratitude!
… On Aug 17, 2017, at 10:16 PM, Teddy Katz ***@***.***> wrote:
@not-an-aardvark approved this pull request.
Looks good to me. Thanks!
@tmcw <https://github.com/tmcw> I added you to the eslint/doctrine-team team, so you should now have write access to this repository.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#193 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFkIDryuJaYnTqR6BrOfQyJ7yIxmC5rJks5sZPP9gaJpZM4NBFW6>.
|
|
👍 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192 by allowing numeric identifiers in
scanIdentifier