Use Array.isArray instead of isarray package.

[medanat]

Removes deprecated package.

[jsf-clabot]

All committers have signed the CLA.

[platinumazure]

Hi @medanat, thanks for the pull request!

The package's "engines" field implies that we support all Node versions from 0.10 onward. However, according to node.green, Array.isArray is only fully supported from Node 6.x onward. So I don't think we can accept this without breaking support for older Node versions, which would require a major release. I'm not saying we can never accept this, but we need to decide if we want to continue supporting older versions of Node first.

[soda0289]

@platinumazure I'm pretty sure Array.isArray() is supported in nodejs v0.10. All the test are passing even with this change. Node.green is referring to array subclasses and Proxy classes. Older browsers < IE 9 do not support isArray() and would require the package.

[medanat]

I can confirm Array.isArray is available on Node 0.10.0

[platinumazure]

My mistake. Unless someone else beats me to it, I'll check again tomorrow and merge if all looks well. Thanks for your patience!

…

On May 27, 2017 3:00 PM, "medanat" ***@***.***> wrote: I can confirm Array.isArray is available on Node 0.10.0 [image: node-0 10 0] <https://cloud.githubusercontent.com/assets/969646/26524062/92e151fa-42f5-11e7-8f1b-154b54332f87.jpg> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#195 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARWesOYwwsHZ55c7PSdnwDb05UXY2bFks5r-IDygaJpZM4NocAT> .

[medanat]

Thanks @platinumazure!

[JaKXz]

🔥

[platinumazure]

LGTM, just want a second set of eyes.

Ping @eslint/eslint-team, can we review and merge this? Thanks!