This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
fix: Making sure union type stringification respects compact flag #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mitermayer
commented
Sep 18, 2017
| @@ -237,7 +237,7 @@ describe('Expression', function () { | |||
| type: doctrine.Syntax.NameExpression, | |||
| name: 'Number' | |||
| }] | |||
| }).should.equal('(String|Number)'); | |||
| }, {compact: false }).should.equal('(String | Number)'); | |||
There was a problem hiding this comment.
I modified this line of code to make this test more explicit on the flag that has been used
mitermayer
commented
Sep 18, 2017
| @@ -248,7 +248,7 @@ describe('Expression', function () { | |||
| type: doctrine.Syntax.NameExpression, | |||
| name: 'Number' | |||
| }] | |||
| }, { topLevel: true }).should.equal('String|Number'); | |||
| }, { topLevel: true, compact: true }).should.equal('String|Number'); | |||
There was a problem hiding this comment.
I have also explicitly set the compact flag to true on this test to assure that the compact behavior still works as expected
3 similar comments
|
anyone can look into this ??? :( |
platinumazure
approved these changes
Oct 8, 2017
|
LGTM, just want another set of eyes on this. Thanks for contributing! |
|
@platinumazure any news around this issue ? |
|
@platinumazure any news on this ? keen to delete some work around hacks from a project that i am working on that depends on this |
not-an-aardvark
approved these changes
Oct 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other types on
stringifyImplcurrently supports the compact flag butUnionType.Currently regardless of the compact flag Uniontypes are printed as
This PR adds support for printing as:
fixes: #200