This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Fix: Remove redundant LICENSE/README names from files #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
approved these changes
Nov 10, 2017
not-an-aardvark
approved these changes
Nov 10, 2017
|
I tested this by running |
|
unrelated: it's weird that we didn't release 2.0.1, but a tag was there. need to delete? |
|
Release consists of two parts, github release and npm release. Unfortunately the error we ran into was after github release was already done, but npm release hasn't started yet. At this point we need to manually push the release to NPM. |
tmcw
pushed a commit
to documentationjs/doctrine
that referenced
this pull request
Apr 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm already includes all of the files (even the ones for Closure Compiler and esprima). On the other hand, release-ops will no longer normalize line endings for the LICENSE files before publishing, but I assume those files' line endings are not as critical.
This should allow the project to be released, in theory.