Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit-message checker should link to a dedicated page explaining what went wrong #64

Closed
not-an-aardvark opened this issue Feb 9, 2018 · 3 comments · Fixed by #131
Closed

Comments

@not-an-aardvark
Copy link
Member

For example, if a user's PR title is too long, the status check could link to something like this:

https://eslint.org/commit-message-statuses?reason=too-long&type=pr-title

Then some JavaScript on that page would render a specific description of what the user needs to fix. This could make it easier for the user to figure out specifically what is wrong with their PR.

@not-an-aardvark
Copy link
Member Author

As an alternative to this, we could also look into making the plugin use GitHub Checks to report a more detailed status message.

@anikethsaha
Copy link
Member

I have thought about the implementation of this.

How about having error codes, many be using a combination of numbers eg : CM203 etc.

We can have them documented in main docs here and even in this docs.

like this

- CM203: commit message length is greater than 72
...

And in the plugins' code, we will create an array for the error codes and push the code in that, and while showing the final message, simply show that array using ,join .

so it would be like

Commit message doesn't follow guidelines, error codes : CM203, CM200 

Thoughts ?

@nzakas
Copy link
Member

nzakas commented Jul 20, 2020

I’m not a fan of error codes — they are too far away from useful information to end users.

Given that we can modify the commit messages when we merge PRs, I’m not sure we need this level of checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants