fix: revert node v20 & upgrade deps #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the changes are going in the reverse of what we want? Can you double check the diff? |
|
If the goal is to get back to b818e1b, there are still a lot of changes left ( For example, CI is still testing on Node 20. |
|
I think the problem is that this branch starts from b818e1b. Maybe the following could help: $ git checkout issue212
$ git reset main --hard
$ git revert HEAD~3..HEAD |
mdjermanovic
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it reverts the following commits:
it reopens the issue: #205
fixes #212