Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List entry without followed empty line eliminates configuration/skip comments #76

Closed
vsemozhetbyt opened this issue Jul 4, 2017 · 0 comments

Comments

@vsemozhetbyt
Copy link

vsemozhetbyt commented Jul 4, 2017

eslint@4.1.1, eslint-plugin-markdown@1.0.0-beta.7

Test doc 1:

* List entry

<!-- eslint-disable strict -->
```js
console.log('a');
```

* List entry

<!-- eslint-skip -->
```js
> console.log('a');
```

No errors.

Test doc 2:

* List entry
<!-- eslint-disable strict -->
```js
console.log('a');
```

* List entry
<!-- eslint-skip -->
```js
> console.log('a');
```

Comments are ignored:

   4:1  error  Use the global form of 'use strict'     strict
  10:1  error  Parsing error: Unexpected token >

No other block or span Markdown elements have this issue. All list elements (unordered with * + - or ordered with 1. ...) have the same issue (both one- and multiline).

@vsemozhetbyt vsemozhetbyt changed the title List entry without followed empty line eliminate configuration/skip comments List entry without followed empty line eliminates configuration/skip comments Jul 4, 2017
btmills added a commit that referenced this issue Mar 1, 2021
Comment attachment was sensitive to whitespace around the code block and
preceding comments. In some cases, the parser would place comments as
descendants of code blocks' preceding sibling nodes. However, a
depth-first traversal of the tree will still encounter the comments in
linear order, which is sufficient for our purposes.
btmills added a commit that referenced this issue Mar 1, 2021
Comment attachment was sensitive to whitespace around the code block and
preceding comments. In some cases, the parser would place comments as
descendants of code blocks' preceding sibling nodes. However, a
depth-first traversal of the tree will still encounter the comments in
linear order, which is sufficient for our purposes.
@btmills btmills added this to Needs Triage in Triage via automation Mar 7, 2021
@btmills btmills moved this from Needs Triage to Pull Request Opened in Triage Mar 7, 2021
Triage automation moved this from Pull Request Opened to Complete Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Triage
Complete
Development

No branches or pull requests

3 participants