Chore: Upgrade to eslint-config-eslint@5.0.1 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior config was still enforcing ES5 coding standards. The earliest supported version of Node.js is 6.14.0, so this lets us use all the nice ES6 features.
|
Is this PR required to enable ES6 linting? |
|
@klappy I don't think so. eslint-config-eslint is used for linting within this project, so this change benefits contributors to this project but not users of this plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior config was still enforcing ES5 coding standards. The earliest supported version of Node.js is 6.14.0, so this lets us use all the nice ES6 features.
I split this into multiple commits to ease review:
npm installing the right versions.npm run lint -- --fix.assert.equaltoassert.strictEqual.