-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix failing tests #163
Conversation
Hi @Trott!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
bc59796
to
1850b90
Compare
Two tests are written that require ESLint@7, but the project specifies ESLint@6. Require ESLint@7 in devDependencies. BREAKING CHANGE: ESLint@7 does not support Node.js 8.x.
(Fixed the issues flagged by the bot and force pushed. This is ready to be reviewed.) |
Hi @Trott, thanks for pointing this out! This plugin is compatible with the ESLint v6 processor API, and most of the unit tests use that. The examples use the friendlier ESLint v7 processor API. As a way to verify both work, we run the examples as an additional test step. CI runs the Ideally there'd be a way to automatically run |
Previously, CI was explicitly running the `install-examples` script as its own step. This was also necessary but not documented locally, so `git clone; npm install; npm test` would show a couple failures when the examples inherited the wrong ESLint dependency. The examples' dependencies should now be installed automatically when running `npm install` locally without any arguments. Originally reported in #163.
Previously, CI was explicitly running the `install-examples` script as its own step. This was also necessary but not documented locally, so `git clone; npm install; npm test` would show a couple failures when the examples inherited the wrong ESLint dependency. The examples' dependencies should now be installed automatically when running `npm install` locally without any arguments. Originally reported in #163.
Previously, CI was explicitly running the `install-examples` script as its own step. This was also necessary but not documented locally, so `git clone; npm install; npm test` would show a couple failures when the examples inherited the wrong ESLint dependency. The examples' dependencies should now be installed automatically when running `npm install` locally without any arguments. Originally reported in #163.
Previously, CI was explicitly running the `install-examples` script as its own step. This was also necessary but not documented locally, so `git clone; npm install; npm test` would show a couple failures when the examples inherited the wrong ESLint dependency. The examples' dependencies should now be installed automatically when running `npm install` locally without any arguments. Originally reported in #163.
Previously, CI was explicitly running the `install-examples` script as its own step. This was also necessary but not documented locally, so `git clone; npm install; npm test` would show a couple failures when the examples inherited the wrong ESLint dependency. The examples' dependencies should now be installed automatically when running `npm install` locally without any arguments. Originally reported in #163.
Two tests are written that require ESLint@7, but the project specifies
ESLint@6. Move to ESLint@7.
BREAKING CHANGE: ESLint@7 drops support for Node.js 8.x.