Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Work around npm behavior changes to fix CI on main #206

Merged
merged 2 commits into from
Jun 21, 2022
Merged

ci: Work around npm behavior changes to fix CI on main #206

merged 2 commits into from
Jun 21, 2022

Commits on Jun 19, 2022

  1. ci: Prevent recursive prepare script invocations 

    A change between npm 8.9 and 8.10 started running the main package's
`prepare` script as part of the examples' installs. This broke CI when
the install step launched a fork bomb and got killed after several
minutes.

This change should fix builds on `main`.
    @btmills
    btmills committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    ff65991 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. ci: Link with legacy peer deps 

    Something about peer dependencies changed between npm 8.5.5 and 8.6.0
that is causing CI to fail on `main` with ESLint 6 on the test matrix.

This works around the issue.
    @btmills
    btmills committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    0240abb View commit details
    Browse the repository at this point in the history