Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure clean build environment before release #8

Closed
nzakas opened this issue Mar 25, 2016 · 0 comments
Closed

Ensure clean build environment before release #8

nzakas opened this issue Mar 25, 2016 · 0 comments
Labels
bug

Comments

@nzakas
Copy link
Member

nzakas commented Mar 25, 2016

Currently, we do only an npm update during release, but this can lead to errors with bundling:
eslint/eslint#5680

It would be better to completely remove node_modules and install using --production to ensure that the correct packages are included.
@nzakas nzakas added the bug label Mar 25, 2016
@nzakas nzakas closed this as completed in 8af49ea Mar 25, 2016
nzakas added a commit that referenced this issue Mar 25, 2016
@nzakas
Merge pull request #9 from eslint/issue8
4d947af 
Fix: Ensure bundled dependencies are correct (fixes #8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nzakas