feat!: Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: eslint/eslint#17595 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
mdjermanovic
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
LGTM, thanks!
I'll leave this open since we didn't explicitly mention that we'll update Node.js requirements in all packages.
Also, if we're going to release eslint-scope v8.0.0, I think it would be good to take the opportunity to include #114 in it rather than in a minor/patch version. While it's technically a bug fix, changes in scoping can be disruptive.
nzakas
approved these changes
Dec 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: eslint/eslint#17595