Update: support new export syntax #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
bradzacher
reviewed
May 3, 2020
| ExportDeclaration(node) { | ||
| this.visitExportDeclaration(node); | ||
| } | ||
|
|
||
| ExportAllDeclaration(node) { | ||
| this.visitExportDeclaration(node); |
There was a problem hiding this comment.
shouldn't this just be empty?
ExportAllDeclaration is specced to always have a source (eg it always exports from an external module and defines no local variables).
I know that visitExportDeclaration does if (node.source) { do nothing }, but why bother with the function call?
There was a problem hiding this comment.
Because I thought that people expect the method visitExportDeclaration to be called on all export declarations because of the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
eslint-scopeto support newexport * as foo from "source"syntax in ES2020.The syntax has added the
exportedproperty into theExportAllDeclarationnode foras foo. Thefooidentifier makes no references, soeslint-scopemust ignore theexportedproperty.In more general,
eslint-scopeshould ignore theExport(All|Default|Named)Declarationnodes if the node has theirsourceproperty (FromClause). Currentlyeslint-scopedoes so for onlyExportNamedDeclaration, therefore this PR addsExport(All|Default)Declaration, too.