Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep eslintbot in all_authors.json #238

Closed
mdjermanovic opened this issue Jun 22, 2022 · 3 comments · Fixed by #255
Closed

Keep eslintbot in all_authors.json #238

mdjermanovic opened this issue Jun 22, 2022 · 3 comments · Fixed by #255
Labels
accepted bug Something isn't working
Projects
Triage

Comments

@mdjermanovic
Copy link
Member

We have added eslintbot into all_authors.json because it will be the default author for release blog posts.

But our data update script overwrites all_authors.json with the list of authors from existing blog posts, so it will always remove eslintbot. This just happened in db3b33b
@eslint-github-bot eslint-github-bot bot added this to Needs Triage in Triage Jun 22, 2022
@nzakas nzakas added bug Something isn't working accepted and removed triage labels Jun 22, 2022
@nzakas nzakas moved this from Needs Triage to Ready to Implement in Triage Jun 22, 2022
@nzakas
Copy link
Member

nzakas commented Jun 22, 2022

This is happening in fetch-team-data.js. We should just merge data into the file instead of overwriting.

@amareshsm
Copy link
Member

I would like give a try. Can I pick this?

@snitin315
Copy link
Contributor

@amareshsm sure, feel free.

@mdjermanovic mdjermanovic mentioned this issue Jul 2, 2022
Closed
19 tasks
nzakas added a commit that referenced this issue Jul 4, 2022
@nzakas
chore: Ensure authors are never overwritten
2261382 
Fixes #238
@nzakas nzakas mentioned this issue Jul 4, 2022
Merged
Triage automation moved this from Ready to Implement to Complete Jul 5, 2022
nzakas added a commit that referenced this issue Jul 5, 2022
@nzakas
chore: Ensure authors are never overwritten (#255)
c2aebfc 
Fixes #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted bug Something isn't working
Projects
Triage
Archived in project
Triage
Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Ensure authors are never overwritten eslint/eslint.org
4 participants
@nzakas @amareshsm @mdjermanovic @snitin315