chore: added redirects #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
reviewed
Mar 18, 2022
src/static/_redirects
Outdated
Comment on lines
15
to
20
| /docs https://eslint.org/ 301! | ||
| /docs/user-guide/rules https://eslint.org/docs/rules 301! | ||
| /docs/rules/id-blacklist https://eslint.org/docs/rules/id-denylist 301! | ||
|
|
||
| /docs/0.24.1/command-line-interface https://eslint.org/docs/user-guide/command-line-interface 301! | ||
| /docs/0.24.1/configuring https://eslint.org/docs/user-guide/configuring 301! |
There was a problem hiding this comment.
I believe we don't need these internal redirects for docs since we will have a separate website for docs.
/cc @nzakas can you confirm?
There was a problem hiding this comment.
I believe we don't need these internal redirects for docs since we will have a separate website for docs.
Thought we might later on update the links. For now wanted to add proper working links
There was a problem hiding this comment.
For now all we need is /docs/* redirecting to eslint.org/docs/*
Later we can change to docs.eslint.org/*
nzakas
reviewed
Mar 22, 2022
src/static/_redirects
Outdated
| /docs/* https://eslint.org/ 301! |
There was a problem hiding this comment.
Suggested change
| /docs/* https://eslint.org/ 301! | |
| /docs/* https://eslint.org/docs/:splat 302! |
We need to cover all docs URLs and definitely don’t want this to be permanent.
snitin315
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: