Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add pre commit hook #292

Merged
merged 11 commits into from Sep 7, 2022
Merged

Conversation

amareshsm
Copy link
Member

@amareshsm amareshsm commented Aug 2, 2022

Description:

  1. Added pre-commit hook with yorkie to lint staged files and minify SVG files.
  2. Added scripts to lint .{js,jsx} and .scss files
  3. Added script to minify SVG files using svgo.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 87aac5f
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/6318dc33824d97000abf6114
😎 Deploy Preview https://deploy-preview-292--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 87aac5f
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/6318dc33309deb00079a5cc8
😎 Deploy Preview https://deploy-preview-292--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 87aac5f
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/6318dc33906cec0008053ed5
😎 Deploy Preview https://deploy-preview-292--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 87aac5f
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/6318dc333f51480008012afe
😎 Deploy Preview https://deploy-preview-292--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 87aac5f
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/6318dc3336c9210008fa14af
😎 Deploy Preview https://deploy-preview-292--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 87aac5f
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/6318dc330e70600008129990
😎 Deploy Preview https://deploy-preview-292--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 87aac5f
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/6318dc3348ebf00008a5cf27
😎 Deploy Preview https://deploy-preview-292--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

.husky/pre-commit Outdated Show resolved Hide resolved
@nzakas
Copy link
Member

nzakas commented Aug 3, 2022

Thanks for taking a stab at this. A few things:

  1. please provide a complete description when submitting a pull request. The description should list out all the changes you made so that it’s easy to understand what you did. Can you please update the description?
  2. Changes to build system should be either “chore” or “build”. “feat” is only for end-user facing changes.
  3. We generally use Yorkie instead of Husky for precommit hooks.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@amareshsm amareshsm changed the title feat: Add pre commit hook build: Add pre commit hook Aug 3, 2022
@amareshsm amareshsm removed the feature label Aug 3, 2022
@amareshsm
Copy link
Member Author

Fixing the lint error. I will update this PR soon.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Sep 3, 2022

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 87aac5f
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/6318dc3338cbe60008f30847
😎 Deploy Preview https://deploy-preview-292--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit cd2b7ad into eslint:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants