Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ESM import syntax in blog post #335

Merged
merged 2 commits into from Aug 30, 2022
Merged

fix: ESM import syntax in blog post #335

merged 2 commits into from Aug 30, 2022

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Aug 29, 2022

Corrects the syntax for importing FlatESLint.

@eslint-github-bot eslint-github-bot bot added bug Something isn't working triage labels Aug 29, 2022
@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 5e1ece2
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/630e4bf458c7110008f7dc71
😎 Deploy Preview https://deploy-preview-335--zh-hans-eslint.netlify.app/blog/2022/08/new-config-system-part-3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 5e1ece2
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/630e4bf4c1540b0008b1f476
😎 Deploy Preview https://deploy-preview-335--new-eslint.netlify.app/blog/2022/08/new-config-system-part-3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 5e1ece2
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/630e4bf40e69c700093c9d38
😎 Deploy Preview https://deploy-preview-335--es-eslint.netlify.app/blog/2022/08/new-config-system-part-3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 5e1ece2
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/630e4bf439d0610008b6e559
😎 Deploy Preview https://deploy-preview-335--ja-eslint.netlify.app/blog/2022/08/new-config-system-part-3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 5e1ece2
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/630e4bf491d70b000aa20bf4
😎 Deploy Preview https://deploy-preview-335--fr-eslint.netlify.app/blog/2022/08/new-config-system-part-3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 5e1ece2
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/630e4bf4f7ee0b000909b3f9
😎 Deploy Preview https://deploy-preview-335--de-eslint.netlify.app/blog/2022/08/new-config-system-part-3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 5e1ece2
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/630e4bf43b59b0000a4bbd4e
😎 Deploy Preview https://deploy-preview-335--hi-eslint.netlify.app/blog/2022/08/new-config-system-part-3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 5e1ece2
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/630e4bf4ef1403000986c17f
😎 Deploy Preview https://deploy-preview-335--pt-br-eslint.netlify.app/blog/2022/08/new-config-system-part-3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdjermanovic
Copy link
Member

You correctly fixed import { FlatRuleTester }, but there's also import { FlatESLint }

@nzakas
Copy link
Member Author

nzakas commented Aug 30, 2022

Oops, thanks.

@mdjermanovic mdjermanovic merged commit a9fc84c into main Aug 30, 2022
@mdjermanovic mdjermanovic deleted the flat-config-esm-fix branch August 30, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants