Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update add-author.js to concat empty string instead of null #340

Merged
merged 1 commit into from Sep 5, 2022

Conversation

harish-sethuraman
Copy link
Member

fixes #331

@eslint-github-bot eslint-github-bot bot added triage bug Something isn't working labels Sep 4, 2022
@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit bd0e943
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/6314efdba96b05000826ad3e
😎 Deploy Preview https://deploy-preview-340--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit bd0e943
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/6314efdb541da0000881fa8d
😎 Deploy Preview https://deploy-preview-340--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit bd0e943
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/6314efdb09673a0009b14d37
😎 Deploy Preview https://deploy-preview-340--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit bd0e943
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/6314efdb53895300093d9032
😎 Deploy Preview https://deploy-preview-340--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit bd0e943
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/6314efdb5cc42c000940f217
😎 Deploy Preview https://deploy-preview-340--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit bd0e943
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/6314efdb6e87e5000873c65a
😎 Deploy Preview https://deploy-preview-340--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit bd0e943
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/6314efdb3170370008cd4162
😎 Deploy Preview https://deploy-preview-340--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit bd0e943
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/6314efdb573c1f00080a3bc1
😎 Deploy Preview https://deploy-preview-340--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit fed8aa1 into main Sep 5, 2022
@nzakas nzakas deleted the null-coerse-bio branch September 5, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update add-author.js
3 participants