Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update css selector for anchors #352

Merged

Conversation

chenxsan
Copy link
Contributor

@chenxsan chenxsan commented Sep 14, 2022

This seems to be a mistake where anchors were generated for sidebar headings as well (those red ones).

I think it should only target the blog content, i.e., the green part.

@netlify
Copy link

netlify bot commented Sep 14, 2022

👷 Deploy request for es-eslint pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cb1a4a5

@eslint-github-bot eslint-github-bot bot added triage bug Something isn't working labels Sep 14, 2022
@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cb1a4a5
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/6321e1edb8f6e800095e9b61
😎 Deploy Preview https://deploy-preview-352--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit cb1a4a5
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/6321e1ed36df9d00089ec072
😎 Deploy Preview https://deploy-preview-352--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit cb1a4a5
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/6321e1ed2805120009eed9e2
😎 Deploy Preview https://deploy-preview-352--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit cb1a4a5
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/6321e1edb8f6e800095e9b66
😎 Deploy Preview https://deploy-preview-352--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit cb1a4a5
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/6321e1ed36df9d00089ec077
😎 Deploy Preview https://deploy-preview-352--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit cb1a4a5
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/6321e1ed074795000937ef39
😎 Deploy Preview https://deploy-preview-352--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit cb1a4a5
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/6321e1ed074795000937ef37
😎 Deploy Preview https://deploy-preview-352--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kecrily kecrily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Copy link
Member

@harish-sethuraman harish-sethuraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@harish-sethuraman harish-sethuraman merged commit ca3462f into eslint:main Sep 14, 2022
@chenxsan chenxsan deleted the fix/update-css-selector-for-anchors branch September 14, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants