Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open rule docs in new tab from the Popup component #367

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

snitin315
Copy link
Contributor

Open docs in a new tab. Because as a user I want to look at the code in the editor and docs back and forth.

Screenshot 2022-11-06 at 2 39 06 PM

Currently, this is also the behavior of links in the console.

Screenshot 2022-11-06 at 2 36 20 PM

@eslint-github-bot eslint-github-bot bot added triage bug Something isn't working labels Nov 6, 2022
@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 773335a
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/636779cfa85290000ae2d94e
😎 Deploy Preview https://deploy-preview-367--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 773335a
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/636779cf62a1a10008d87440
😎 Deploy Preview https://deploy-preview-367--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 773335a
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/636779cf62a1a10008d87445
😎 Deploy Preview https://deploy-preview-367--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 773335a
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/636779cf099d790008ed66bb
😎 Deploy Preview https://deploy-preview-367--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 773335a
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/636779cfdc62d800098dbbcc
😎 Deploy Preview https://deploy-preview-367--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 773335a
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/636779cf62a1a10008d8744a
😎 Deploy Preview https://deploy-preview-367--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 773335a
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/636779cf099d790008ed66c0
😎 Deploy Preview https://deploy-preview-367--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 6, 2022

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 773335a
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/636779d0dc62d800098dbbd2
😎 Deploy Preview https://deploy-preview-367--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kecrily kecrily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snitin315 snitin315 merged commit bb22e67 into main Nov 6, 2022
@snitin315 snitin315 deleted the fix/docs-in-new-tab branch November 6, 2022 12:55
@snitin315 snitin315 added accepted and removed triage labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants