Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch language based on current path #380

Merged
merged 1 commit into from Dec 9, 2022

Conversation

kecrily
Copy link
Member

@kecrily kecrily commented Dec 7, 2022

Prerequisites checklist

What is the purpose of this pull request?

Improve the experience of language switching

What changes did you make? (Give an overview)

Instead of directing users to homepages in other languages for no reason, they are redirected to corresponding pages in other languages based on the path of the current page

Related Issues

Is there anything you'd like reviewers to focus on?

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit b0f4257
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/6390bad7e439f4000896141a
😎 Deploy Preview https://deploy-preview-380--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit b0f4257
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/6390bad7eaeda200085d966c
😎 Deploy Preview https://deploy-preview-380--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit b0f4257
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/6390bad7570ea60008816e71
😎 Deploy Preview https://deploy-preview-380--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit b0f4257
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/6390bad7a147700008ef76af
😎 Deploy Preview https://deploy-preview-380--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit b0f4257
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/6390bad7753e9100082afd9d
😎 Deploy Preview https://deploy-preview-380--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit b0f4257
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/6390bad70b3e610008d26571
😎 Deploy Preview https://deploy-preview-380--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit b0f4257
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/6390bad789951f000798b73f
😎 Deploy Preview https://deploy-preview-380--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 7, 2022

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit b0f4257
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/6390bad7475e630008256782
😎 Deploy Preview https://deploy-preview-380--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@amareshsm amareshsm added accepted and removed triage labels Dec 7, 2022
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just leaving so @eslint/website-team can approve.

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀, thanks.

@harish-sethuraman harish-sethuraman merged commit 6fcded7 into main Dec 9, 2022
@harish-sethuraman harish-sethuraman deleted the feat/switch-current branch December 9, 2022 19:38
kecrily added a commit to eslint/eslint that referenced this pull request Dec 20, 2022
kecrily added a commit to eslint/eslint that referenced this pull request Dec 20, 2022
mdjermanovic added a commit to eslint/eslint that referenced this pull request Apr 1, 2023
* docs: switch language based on current path

ref eslint/eslint.org#380

* fix: redirect to latest when version isn't latest

* Update docs/src/_includes/components/language-switcher.html

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>

---------

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants