Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display of nav toggle button #411

Merged
merged 1 commit into from Feb 2, 2023

Conversation

Tanujkanti4441
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

The display of toggle button of navbar is none in 680px screen width while the nav-list is also hidden.

Screenshot 2023-02-02 201820

What changes did you make? (Give an overview)

just set the media query min-width to 681px so the display of the toggle button will be none on 681px

Related Issues

Is there anything you'd like reviewers to focus on?

@netlify
Copy link

netlify bot commented Feb 2, 2023

👷 Deploy request for es-eslint pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c3f1fd6

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Feb 2, 2023
@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit c3f1fd6
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/63dbd0e2c59f6400092c42ab
😎 Deploy Preview https://deploy-preview-411--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit c3f1fd6
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/63dbd0e238d5a40009a8f84b
😎 Deploy Preview https://deploy-preview-411--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit c3f1fd6
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/63dbd0e213193c00080e23b6
😎 Deploy Preview https://deploy-preview-411--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit c3f1fd6
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/63dbd0e2a246d600086982f6
😎 Deploy Preview https://deploy-preview-411--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit c3f1fd6
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/63dbd0e26704e60008db30d9
😎 Deploy Preview https://deploy-preview-411--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit c3f1fd6
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/63dbd0e22af1f20009ed9d68
😎 Deploy Preview https://deploy-preview-411--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c3f1fd6
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/63dbd0e2e6ae1e0009d95a31
😎 Deploy Preview https://deploy-preview-411--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kecrily kecrily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kecrily kecrily added documentation Improvements or additions to documentation accepted and removed triage labels Feb 2, 2023
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit e7d21b5 into eslint:main Feb 2, 2023
@Tanujkanti4441 Tanujkanti4441 mentioned this pull request Feb 4, 2023
1 task
@Tanujkanti4441 Tanujkanti4441 deleted the nav-toggle-display branch February 9, 2023 14:06
@Tanujkanti4441 Tanujkanti4441 restored the nav-toggle-display branch February 14, 2023 14:14
@Tanujkanti4441 Tanujkanti4441 deleted the nav-toggle-display branch July 23, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants