Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate ESLint setup to flat configuration #512

Merged
merged 9 commits into from
Feb 21, 2024

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Migrate ESLint to flat config.

What changes did you make? (Give an overview)

Followed the configuration migration guide

Related Issues

NA

Is there anything you'd like reviewers to focus on?

NA

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 0f94ba1
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/65d578d7acb96700081110ab
😎 Deploy Preview https://deploy-preview-512--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 0f94ba1
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/65d578d74283fb0008d9b08e
😎 Deploy Preview https://deploy-preview-512--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 0f94ba1
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/65d578d76c63dc00083a7423
😎 Deploy Preview https://deploy-preview-512--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 0f94ba1
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/65d578d75d34580008d5eaa0
😎 Deploy Preview https://deploy-preview-512--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 0f94ba1
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/65d578d71cf0b10008242185
😎 Deploy Preview https://deploy-preview-512--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 0f94ba1
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/65d578d7338ac90008065a5c
😎 Deploy Preview https://deploy-preview-512--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 0f94ba1
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/65d578d72d69c50008551222
😎 Deploy Preview https://deploy-preview-512--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 0f94ba1
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/65d578d71a50740008a55bf0
😎 Deploy Preview https://deploy-preview-512--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@snitin315 snitin315 marked this pull request as ready for review January 26, 2024 11:08
package.json Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending @aladdin-add's comments.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting @mdjermanovic take another look.

eslint.config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
package.json Outdated
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint": "^8.56.0",
"eslint-config-eslint": "^9.0.0",
"eslint-plugin-jsx-a11y": "^6.8.0",
"eslint-plugin-node": "^11.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"eslint-plugin-node": "^11.1.0",

We can now remove this.

Note: package-lock.json should probably also be updated after this is removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, removed!

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit a3d0169 into main Feb 21, 2024
37 checks passed
@mdjermanovic mdjermanovic deleted the move-to-flat-config branch February 21, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

6 participants