add two more cases

eslint · Dec 9, 2023 · 0541585 · 0541585
1 parent 3a22236
commit 0541585
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/lib/rules/no-implicit-coercion.js b/lib/rules/no-implicit-coercion.js
@@ -300,6 +300,13 @@ module.exports = {
 
                     report(node, recommendation, true);
                 }
+
+                // -(-foo)
+                if (node.operator === "-" && node.argument.type === "UnaryExpression" && node.argument.operator === "-") {
+                    const recommendation = `Number(${sourceCode.getText(node.argument.argument)})`;
+
+                    report(node, recommendation, true);
+                }
             },
 
             // Use `:exit` to prevent double reporting
@@ -317,6 +324,13 @@ module.exports = {
                     report(node, recommendation, true);
                 }
 
+                // foo - 1
+                if (node.operator === "-" && isNumeric(node.right) && node.right.value === 0) {
+                    const recommendation = `Number(${sourceCode.getText(node.left)})`;
+
+                    report(node, recommendation, true);
+                }
+
                 // "" + foo
                 operatorAllowed = options.allow.includes("+");
                 if (!operatorAllowed && options.string && isConcatWithEmptyString(node)) {

diff --git a/tests/lib/rules/no-implicit-coercion.js b/tests/lib/rules/no-implicit-coercion.js
@@ -157,6 +157,15 @@ ruleTester.run("no-implicit-coercion", rule, {
                 type: "UnaryExpression"
             }]
         },
+        {
+            code: "-(-foo)",
+            output: "Number(foo)",
+            errors: [{
+                messageId: "useRecommendation",
+                data: { recommendation: "Number(foo)" },
+                type: "UnaryExpression"
+            }]
+        },
         {
             code: "+foo.bar",
             output: "Number(foo.bar)",
@@ -193,6 +202,15 @@ ruleTester.run("no-implicit-coercion", rule, {
                 type: "BinaryExpression"
             }]
         },
+        {
+            code: "foo.bar-0",
+            output: "Number(foo.bar)",
+            errors: [{
+                messageId: "useRecommendation",
+                data: { recommendation: "Number(foo.bar)" },
+                type: "BinaryExpression"
+            }]
+        },
         {
             code: "\"\"+foo",
             output: "String(foo)",