Fix: make overrides[].files matching dotfiles (fixes #11201) (#11225)

eslint · Apr 1, 2019 · 19248e0 · 19248e0
1 parent 0fb5fd4
commit 19248e0
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 1 deletion.
diff --git a/lib/config/config-ops.js b/lib/config/config-ops.js
@@ -366,7 +366,7 @@ module.exports = {
             }
         });
 
-        const opts = { matchBase: true };
+        const opts = { dot: true, matchBase: true };
 
         return patternList.some(pattern => minimatch(filePath, pattern, opts)) &&
             !excludedPatternList.some(excludedPattern => minimatch(filePath, excludedPattern, opts));

diff --git a/tests/fixtures/cli-engine/overrides-with-dot/.eslintrc.yml b/tests/fixtures/cli-engine/overrides-with-dot/.eslintrc.yml
@@ -0,0 +1,6 @@
+root: true
+
+overrides:
+  - files: "*.js"
+    rules:
+      no-unused-vars: error
diff --git a/tests/fixtures/cli-engine/overrides-with-dot/.test-target.js b/tests/fixtures/cli-engine/overrides-with-dot/.test-target.js
@@ -0,0 +1 @@
+var a = 0
diff --git a/tests/lib/cli-engine.js b/tests/lib/cli-engine.js
@@ -2870,6 +2870,23 @@ describe("CLIEngine", () => {
                 }, "No files matching 'non-exist.js' were found.");
             });
         });
+
+        describe("overrides", () => {
+            beforeEach(() => {
+                engine = new CLIEngine({
+                    cwd: getFixturePath("cli-engine/overrides-with-dot"),
+                    ignore: false
+                });
+            });
+
+            it("should recognize dotfiles", () => {
+                const ret = engine.executeOnFiles([".test-target.js"]);
+
+                assert.strictEqual(ret.results.length, 1);
+                assert.strictEqual(ret.results[0].messages.length, 1);
+                assert.strictEqual(ret.results[0].messages[0].ruleId, "no-unused-vars");
+            });
+        });
     });
 
     describe("getConfigForFile", () => {